0.0.3 release

[cdrage]

Been 21 days since the last release. Down for another one?

Now that we have rtmp updated + windows docs + debian deb package installer thingy, it makes sense.

Let me know if there any blockers on this, otherwise, I can do a release later tomorrow.

[gravyboat]

We aren't building the Windows installer automatically yet is my only concern for creating more manual work. @sbstp opinions?

[RangerCoder99]

Thank you so much for updating this project, and all your hard work on this!

[cdrage]

@gravyboat I should add this to the release / build script we have.

[sbstp]

I'd like to add some polish if you guys don't mind. Shouldn't be too long, it's just the config file thingy on Windows.

[gravyboat]

I'm fine with waiting @sbstp! Having the config file taken care of would be good for typical users (I am assuming that is what you are referring to, if not let me know).

[karlo2105]

Could you do something like chrippa did with automatically nightly build : http://livestreamer-builds.s3.amazonaws.com/livestreamer-latest-win32.zip

[sbstp]

Yeah, the first time you run streamlink, it would create the file in %APPDATA%, and I might also add a switch such as streamlink --edit-config that starts an editor (windows notepad, unix nano/vim/emacs/$EDITOR) with the config file. You're right though, it can wait.

[gravyboat]

@sbstp The editor idea is a good idea! Thanks for prioritizing the configuration file, it's super helpful to have that available. @karlo2105 personally I am not a fan of nightly builds, people use them and then ask for support when instead they could just compile it themselves if they want the latest release.

[thinkpad4]

Sbstp, are you gonna make another windows .exe installer for 0.0.3 like you did for 0.0.2?

[sbstp]

Yes I will.

[thinkpad4]

<3 Thank you very much

[karlo2105]

@gravyboat
Nightlybuild is interesting when you want to update streamlink locally altogether on Windows.
Otherwise you are obliged to update step by step every part of streamlink.
I like to have choice, nobody has problems with nightly builds with Livestreamer and no one is obliged to use nightlybuilds.

[dehesselle]

Hey guys,
I wanted to drop by and thank you for stepping in where Livestreamer left off. Also I'd like to mention that Streamlink is part of the macOS app of Chatty that I'm starting to maintain. I'm hoping that's fine with you?

[gravyboat]

@dehesselle Sounds good to me. I don't have any concerns about including it.

[cdrage]

@dehesselle that's awesome by us, if you need any addition macOS bugs / fixes feel free to open up any new issues and we'd be on it.

[ghost]

Any progress?

[scottbernstein-zz]

I think that all of this work @beardypig has been doing on the ustream plugin will be nice to have in the 0.0.3 release.

---

From: Hyungoo Kang notifications@github.com
Sent: Tuesday, November 8, 2016 3:38:19 AM
To: streamlink/streamlink
Subject: Re: [streamlink/streamlink] 0.0.3 release (#116)

Any progress?

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/116#issuecomment-259077049, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AESJ1tAc9F483_nz2uA3ozyE0Rup0qi2ks5q8DT7gaJpZM4Knhai.

[gravyboat]

@cyluss We're waiting on a few things to be finished prior to doing this, ustream would be nice to have, but more important to me is the Windows config file being available by default.

[ghost]

So #81 is blocker, right?

[gravyboat]

@cyluss Correct.

[cdrage]

Hey @beardypig so I think it's time for another release (with the Windows .exe).

Do you think that the .exe is ready?

To be honest, I don't have access to a Windows machine at the moment for testing. But if you say it's working fine, I'm okay with the release.

I'll test Linux, you test Windows :)

Give me the go-ahead for the current code in master and I'll compile the .exe and do a release. If there's an issue (luckily) it's as simple creating a patch and doing another release.

[beardypig]

I actually use macOS most of the time, but I do use a Windows 10 VM for testing. The current master version was working well when I tested it, except you have to update the streamlinkrc files to use rtmpdump - hence my patch for the installer :-)

Would be good if a couple of other users could test out the nightly...

[bastimeyer]

I just tested streamlink-latest.exe in my Windows 7 and 10 VMs.
What about #172 (streamlink.rc)? Shouldn't this be merged first before publishing a new release?

What I noticed about the installer:

• It creates an unnecessary start menu shortcut which might annoy some users
• Publisher infos are missing (name and website)
• The copy-file section should not be closed automatically (I'd like to review the file list). Looks like pynsist is using the nsis 2.0 modern user interface. The MUI_FINISHPAGE_NOAUTOCLOSE constant needs to be defined for this. (default nsis config)
• A final section could be added similar to the Livestreamer installer that suggests editing the config file and/or opening the publisher's website.

[beardypig]

@bastimeyer sounds good, do you want to make some/all of those changes?

[bastimeyer]

@beardypig
Unfortunately, I'm not too familiar with nsis. These were just the first things I noticed after having built an installer myself a couple of months ago which hasn't been published yet.

How can the pynsist default config be changed (or extended / stuff be removed)?

Regarding the shortcut (pynsist docs):

One shortcut will always be generated for the application

😕

[bastimeyer]

Ok, nvm, figured it out.

The shortcut can be removed by overriding the whole install_shortcuts block with an empty one.

The constants can be added by prepending them to the modernui block.

!define MUI_FINISHPAGE_NOAUTOCLOSE
!define MUI_UNFINISHPAGE_NOAUTOCLOSE

I can't manage to add the publisher data, though, as it would require rewriting the whole sections block which contains these lines. (there's no nested block, so there's no nice way (without forking pynsist))

Publisher data (uninstaller, which is listed in the Windows control center):

WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${PRODUCT_NAME}" "DisplayVersion" "..."
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${PRODUCT_NAME}" "Publisher" "..."
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${PRODUCT_NAME}" "URLInfoAbout" "..."
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${PRODUCT_NAME}" "HelpLink" "..."

I can add a PR once #172 gets merged, so that no conflicts occur. It's past 1am here, if you want to do it yourself now, just go for it, I'm going offline. 😄

[gravyboat]

I merged #172.

[beardypig]

@bastimeyer seems pretty straight forward then. It might be possible to tack the publisher info on the end of the install_commands block... Not ideal, but could be tidied up later if pynsist gets a block around the add/remove stuff, or adds a publisher info section to the pynsist configuration...

[gravyboat]

At this point I think we've addressed most of the concerns people had about the 0.0.3 release and it's been over a month since the last release. If there are no further concerns and everyone is happy with what we've done let's get this built. We can always release 0.0.4 much sooner if something crops up that is problematic.

[sbstp]

@gravyboat do you have push access to pypi? If not we need @cdrage for the 0.0.3 release!

[gravyboat]

@sbstp We need @cdrage to do it.

[sbstp]

We need more people to have access to pypi so that the livestreamer story doesn't repeat itself.

[gravyboat]

Agreed. I know sometimes people don't hop on GitHub during the weekend (understandably) so it might need to wait till Monday.

[cdrage]

@sbstp @gravyboat I'll give you guys access to pypi once i'm at a computer on monday. send me your email details @ charlie (at) charliedrage (dot) com if they're different than what's on github.

edit: i'll do the release then too :)

[cdrage]

0.1.0 released!

[gravyboat]

I'm just following up from this note 22 days ago from @cdrage regarding pypi access. A quick google search doesn't seem to elude to the fact that multiple people can share a repo, is this even possible?

[beardypig]

It is possible, there is a "roles" section under the "edit" section for the package on PyPi. You can add another PyPi user as a maintainer. I guess the URL is https://pypi.python.org/pypi?:action=role_form&package_name=streamlink :-)

[gravyboat]

Good find @beardypig, not sure why I couldn't find anything. We should probably add at least 2 more people to the pypi repo for bus factor and all that.

[cdrage]

@gravyboat @beardypig what are your pypi usernames?

[beardypig]

You guessed it, mine is beardypig :)

[cdrage]

@beardypig added you :)

[beardypig]

Confirmed. Thanks :)

[gravyboat]

@cdrage The same as my github username, gravyboat.