Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facebook video does not offer 1080p option #2168

Closed
scottbernstein-zz opened this issue Nov 15, 2018 · 2 comments
Closed

Facebook video does not offer 1080p option #2168

scottbernstein-zz opened this issue Nov 15, 2018 · 2 comments
Labels
out of scope plugin enhancement A new feature for a working Plugin plugin issue A Plugin does not work correctly wontfix This will not be worked on

Comments

@scottbernstein-zz
Copy link

[x ] This is a plugin issue and I have read the contribution guidelines.

Description
Facebook video offers 1080p option but the "best" quality only delivers 720p video

Reproduction steps / Explicit stream URLs to test
https://www.facebook.com/PigeonsPlayingPingPong/videos/477345006006079/

Go to this video. You can see that among the options for resolution is 1080. When I point streamlink at the URL to download and select "best", it only streams the 720p version. The only 2 resolution options presented are "sd" and "hd" (but there are actually 6 distinct resolution options available on the page)

Log output
c:>streamlink https://www.facebook.com/PigeonsPlayingPingPong/videos/477345006006079/ -l debug
[cli][debug] OS: Windows 7
[cli][debug] Python: 3.6.6
[cli][debug] Streamlink: 0.14.2
[cli][debug] Requests(2.19.1), Socks(1.6.7), Websocket(0.53.0)
[cli][info] Found matching plugin facebook for URL https://www.facebook.com/PigeonsPlayingPingPong/videos/47734500600607
9/
Available streams: sd (worst), hd (best)
@back-to back-to mentioned this issue Nov 25, 2018
Closed
1 task
@back-to
Copy link
Collaborator

back-to commented Nov 25, 2018

(but there are actually 6 distinct resolution options available on the page)

these are DASHStreams, they are currently not parsed for the Facebook plugin.

See #2179 for some more details

@back-to back-to added the plugin issue A Plugin does not work correctly label Nov 25, 2018
@back-to back-to mentioned this issue Nov 25, 2018
Closed
1 task
pmrowla added a commit to pmrowla/streamlink that referenced this issue Jan 11, 2019
@pmrowla
plugins.facebook: Handle DASH manifests.
c7386f3 
Addresses streamlink#2168, streamlink#2133.
@pmrowla pmrowla mentioned this issue Jan 11, 2019
Closed
pmrowla added a commit to pmrowla/streamlink that referenced this issue Feb 1, 2019
@pmrowla
plugins.facebook: Support manifest strings and tahoe player urls
ef51037 
Addresses streamlink#2168, streamlink#2133.
Immediate playback for DASH streams with separate audio and video
streams will not be supported until proper SegmentBase handling is
implemented.
@pmrowla pmrowla mentioned this issue Feb 1, 2019
Merged
back-to pushed a commit that referenced this issue Mar 24, 2019
@pmrowla @back-to
plugins.facebook: Support manifest strings and tahoe player urls (#2286)
7e0c9d2 
Immediate playback for DASH streams with separate audio and video
streams will not be supported until proper SegmentBase handling is
implemented.

closes #2133
closes #2164
closes #2324

WIP for #2168
Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this issue May 14, 2020
@pmrowla @Billy2011
plugins.facebook: Support manifest strings and tahoe player urls (str…
4fc6247 
…eamlink#2286)

Immediate playback for DASH streams with separate audio and video
streams will not be supported until proper SegmentBase handling is
implemented.

closes streamlink#2133
closes streamlink#2164
closes streamlink#2324

WIP for streamlink#2168
mkbloke pushed a commit to mkbloke/streamlink that referenced this issue Aug 18, 2020
@pmrowla @back-to
plugins.facebook: Support manifest strings and tahoe player urls (str…
ebc18c5 
…eamlink#2286)

Immediate playback for DASH streams with separate audio and video
streams will not be supported until proper SegmentBase handling is
implemented.

closes streamlink#2133
closes streamlink#2164
closes streamlink#2324

WIP for streamlink#2168
resiproxy pushed a commit to resiproxy/streamlink that referenced this issue Nov 5, 2020
@pmrowla @resiproxy
plugins.facebook: Support manifest strings and tahoe player urls (str…
8a0c941 
…eamlink#2286)

Immediate playback for DASH streams with separate audio and video
streams will not be supported until proper SegmentBase handling is
implemented.

closes streamlink#2133
closes streamlink#2164
closes streamlink#2324

WIP for streamlink#2168
@back-to back-to added wontfix This will not be worked on out of scope plugin enhancement A new feature for a working Plugin labels Sep 25, 2022
@back-to
Copy link
Collaborator

back-to commented Sep 25, 2022

They use custom dash streams, adding them to streamlink is just to much work.

closing

@back-to back-to closed this as completed Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
out of scope plugin enhancement A new feature for a working Plugin plugin issue A Plugin does not work correctly wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottbernstein-zz @back-to