Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teamliquid's new domain tl.net usage broke the corresponding plugin #2416

Closed
ptkovsky opened this issue Apr 10, 2019 · 2 comments · Fixed by #2442
Closed

Teamliquid's new domain tl.net usage broke the corresponding plugin #2416

ptkovsky opened this issue Apr 10, 2019 · 2 comments · Fixed by #2442
Labels
plugin issue A Plugin does not work correctly

Comments

@ptkovsky
Copy link

There's a major issue now where teamliquid's new domain tl.net usage has completely broken the corresponding plugin:

streamlink https://tl.net/video/streams/ioioiobb
error: No plugin can handle URL: https://tl.net/video/streams/ioioiobb
@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Apr 10, 2019
@bastimeyer
Copy link
Member

major issue

This is just a simple regex change, unless they've changed their site's layout.
https://github.com/streamlink/streamlink/blob/1.1.1/src/streamlink/plugins/teamliquid.py#L6

The plugin also still uses the deprecated logger calls and needs to get updated.


Btw, what is the policy on these kinds of wrapper/proxy/alias plugins? I can remember that we had a discussion about this a few months ago, but I can't find the thread. Doesn't this technically violate the third point here?
https://github.com/streamlink/streamlink/blob/1.1.1/CONTRIBUTING.md#plugin-requests

  1. Sites which are primarily rehosting content that is available from a legitimate source

My personal opinion is that these plugins are rather pointless, but at the same time they've existed for a long time now and there are people who are using them.

@gravyboat
Copy link
Member

gravyboat commented Apr 10, 2019

@bastimeyer From what I remember the only reason we kept any of the teamliquid stuff was basically because it was grandfathered in. One of us (probably me since I hate this sort of rehost bloat and I'll happily take the heat) brought up getting rid of these specific types of plugins during some discussion and we came the the conclusion we would allow old plugins to stay, but wouldn't permit future restream plugins like this to exist.

If we ever want to bring down the hammer I'll be happy to put teamliquid and vaughnlive as number one on the chopping block.

back-to added a commit to back-to/streamlink that referenced this issue Apr 21, 2019
Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this issue May 14, 2020
mkbloke pushed a commit to mkbloke/streamlink that referenced this issue Aug 18, 2020
resiproxy pushed a commit to resiproxy/streamlink that referenced this issue Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants