vendor: set requests to >=2.26.0,<3 #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are the tests on Windows randomly failing all of a sudden? Could this be caused by a side effect of #3856? |
- Bump requests to latest version: This replaces transitive dependency chardet with charset-normalizer - Fix Windows installer dependencies: Upgrade dependencies and list them as wheels with strict versions, where possible. pynsist unfortunately doesn't support additional wheel checksums.
bastimeyer
force-pushed
the
deps/requests-2.26.0
branch
from
e83bc3d
to
59f9ee4
Compare
|
We've got two separate issues here. While this fixes the Windows installer CI job, tests on Windows are still randomly failing. The PR can't be merged due to branch protection rules. I'll restart the CI jobs now in hope that the required jobs pass and it can be merged. Otherwise we'll have to disable the protection rules, or I'll have to open a PR with both fixes (which would not be ideal). |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces transitive dependency chardet with charset-normalizer
List dependencies as wheels with strict versions where possible.
pynsist unfortunately doesn't support additional wheel checksums.
This pinpoints the dependency versions to strict values (all up2date), similar to the appimages, except for wheel checksums ("dependency lockfile"), as it's not supported by pynsist:
https://github.com/streamlink/streamlink-appimage/blob/2.2.0-1/config.json
The
iso639dependency is not a wheel, so it has to be kept in thepackagesdirective.Tested a locally built installer in my Win10 VM...
#3862, #3863