Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: temporarily skip broken tests on win32 #3870

Conversation

bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Jul 15, 2021

Temporarily skip EventedHLSStreamWriter related tests on Windows


See #3868

The Windows installer CI job fail until #3864 got merged and this PR rebased onto it

@bastimeyer bastimeyer added os: Windows Related to Microsoft Windows tests labels Jul 15, 2021
@gravyboat
Copy link
Member

#3864 is merged.

Temporarily skip EventedHLSStreamWriter related tests on Windows
@bastimeyer bastimeyer force-pushed the tests/skip-evented-hls-writer-tests-on-windows branch from af5195e to 5020152 Compare July 15, 2021 22:29
@gravyboat gravyboat merged commit 29a25fc into streamlink:master Jul 15, 2021
@bastimeyer
Copy link
Member Author

Btw, this isn't just an issue on Windows. As said, it's more complicated and I haven't been able to figure out a solution yet, but what makes it fail is different thread scheduling on Windows. I have seen failing tests on my native Arch Linux install as well, but only when I ran pytest tests/streams, and not the entire test suite.

@bastimeyer bastimeyer deleted the tests/skip-evented-hls-writer-tests-on-windows branch July 15, 2021 22:36
@gravyboat
Copy link
Member

Huh that's really odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: Windows Related to Microsoft Windows tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants