plugins.vk: _url_re update, allow embedded content, plugin cleanup #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1874 +/- ##
==========================================
+ Coverage 50.51% 50.52% +<.01%
==========================================
Files 238 238
Lines 14077 14073 -4
==========================================
- Hits 7111 7110 -1
+ Misses 6966 6963 -3 |
|
Doh I had some itertags tests here https://github.com/beardypig/streamlink/blob/1e5cecb2591f520bad5ddb54c873d2361491be0b/tests/test_plugin_utils.py, but forgot to include them... |
|
they are in #1675 well they look better, will remove mine. |
|
Looks good @back-to, thanks! |
beardypig
pushed a commit
to beardypig/streamlink
that referenced
this pull request
Jul 25, 2018
…treamlink#1874) * plugins.vk: _url_re update, allow embedded content, plugin cleanup * tests.utils: Removed itertags tests in favor of another PR.
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
…treamlink#1874) * plugins.vk: _url_re update, allow embedded content, plugin cleanup * tests.utils: Removed itertags tests in favor of another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added someitertags testsclose #1584
close #1603