vendor: downgrade requests to 2.25.1 on Windows #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This temporarily fixes the issue of randomly failing tests on Windows which seems to be related to the latest requests version 2.26 and requests-mock, where mocked request responses take an random/arbitrary time to return data, which makes the EventedHLSStreamWriter tests miss their time frames when writing HLS segment data to the output buffer. Since Windows builds of Streamlink don't rely on system python packages like on most Linux distros for example, downgrading and forcing an older version of requests on Windows should be fine. This commit thus partly reverts 35cb8d9 and 29a25fc which fixed the broken dependencies of the Windows installer and skipped the randomly failing tests on Windows.
bastimeyer
added
dependencies
Windows installer
os: Windows
|
Thanks for doing the investigation here @bastimeyer. Bummer that this is an upstream issue. |
This comment has been minimized.
This comment has been minimized.
Which "other dependencies" does this break?
|
|
@bastimeyer nvm. I've fixed it. |
back-to
added a commit
to back-to/streamlink
that referenced
this pull request
Aug 22, 2021
bastimeyer
pushed a commit
that referenced
this pull request
Aug 22, 2021
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporarily fixes the issue of randomly failing tests on
Windows which seems to be related to the latest requests version
2.26 and requests-mock, where mocked request responses take an
random/arbitrary time to return data, which makes the
EventedHLSStreamWriter tests miss their time frames when writing
HLS segment data to the output buffer.
Since Windows builds of Streamlink don't rely on system python
packages like on most Linux distros for example, downgrading and
forcing an older version of requests on Windows should be fine.
This commit thus partly reverts 35cb8d9 and 29a25fc which fixed
the broken dependencies of the Windows installer and skipped the
randomly failing tests on Windows.
Resolves #3868
Even if this resolves #3868 and will make the tests pass again, I'd like to improve/tweak the HLS tests a bit and refactor some of the HLS code. I will submit these changes later, but I'm not sure yet when. After that I'd like to prepare the 2.3.0 release like I've said last week before this whole ordeal began.