plugins.euronews: rewrite and fix using XPath #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
plugins/euronews/xpath
branch
from
1d121ba
to
473ca7a
Compare
back-to
reviewed
Sep 1, 2021
| for elem in itertags(content, "div"): | ||
| if elem.attributes.get("id") == "pfpPlayer" and elem.attributes.get("data-google-src") is not None: | ||
| return elem.attributes.get("data-video-id") | ||
| video_url = root.xpath("string(.//iframe[@id='pfpPlayer'][starts-with(@src,'https://www.youtube.com/')][1]/@src)") |
There was a problem hiding this comment.
VODs (youtube)
Can't find a VOD right now with an embedded YT video
it has meta og:video
but the youtube player is not an iframe
<div id="pfpPlayer"
class="u-height-full u-position-absolute u-width-full">
<div class="js-player-pfp"
style="width: 100%; height: 100%;" data-player="pfp"
data-id="euronews-youtube-pfp"
data-google-src="https://apis.google.com/js/api.js?onload=googleApiClientReady"
data-video-id="lbUnUJsTZCE" data-video-autoplay=""
data-video-isembed="" data-sitename="euronews"
data-color="#003865" data-related="[]" data-hasAds="1"
data-src="/build/b5366582c03145c79ccf-youtube-pfp.js">
<div class="js-playtrigger c-playtrigger "><button
class="js-playtrigger__button c-playtrigger__button"
aria-label="Play the video"></button></div>
</div>
</div>There was a problem hiding this comment.
There are definitely two different implementations on their site. One with a div and data-google-src/data-video-id attributes, and one with a simple iframe.
There was a problem hiding this comment.
bastimeyer
force-pushed
the
plugins/euronews/xpath
branch
from
473ca7a
to
b24f2f5
Compare
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live (main - youtube)
Live (de - youtube)
Live (ru - self hosted)
VODs (self hosted)
VODs (youtube)
Can't find a VOD right now with an embedded YT video