Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.vkplay: new plugin #5054

Merged
merged 3 commits into from
Dec 29, 2022
Merged

plugins.vkplay: new plugin #5054

merged 3 commits into from
Dec 29, 2022

Conversation

Inokenty90
Copy link
Contributor

Plugin to support live streaming on vkplay.live

streamlink https://vkplay.live/sguhoman
[cli][info] Found matching plugin vkplay for URL https://vkplay.live/sguhoman
[cli][info] Available streams: 240p (worst), 360p, 480p, 720p, 1080p (best)

@bastimeyer
Copy link
Member

Thanks for the PR. Adding a plugin for this site should be fine.

However, some code clean up needs to be done here first before this can be merged. Allow me to add some changes to your PR branch, so this doesn't get unnecessarily complicated. I will also add support for API error messages and for stream metadata.

@bastimeyer bastimeyer added plugin request - approved Plugin meets request requirements and a PR for the plugin will be approved PR: squash commits Commits need to be squashed as a single commit - eg. multiple commits for a single component labels Dec 29, 2022
@bastimeyer
Copy link
Member

Metadata:

$ streamlink 'https://vkplay.live/d3l_by' best -j | jq .metadata
{
  "id": "4462052257156",
  "author": "d3l_by",
  "category": "Говорим и смотрим",
  "title": "ВЛОГ2 уже на ютубе!"
}

Offline:

$ streamlink 'https://vkplay.live/sguhoman'
[cli][info] Found matching plugin vkplay for URL https://vkplay.live/sguhoman
error: No playable streams found on this URL: https://vkplay.live/sguhoman

Non-existent:

$ streamlink 'https://vkplay.live/foo'
[cli][info] Found matching plugin vkplay for URL https://vkplay.live/foo
[plugins.vkplay][error] Blog not found
error: No playable streams found on this URL: https://vkplay.live/foo

Copy link
Member

@mkbloke mkbloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/streamlink/plugins/vkplay.py Show resolved Hide resolved
@bastimeyer bastimeyer merged commit d8225bb into streamlink:master Dec 29, 2022
@Inokenty90 Inokenty90 deleted the vkplay branch December 29, 2022 18:19
Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this pull request Jan 6, 2023
Co-Authored-By: bastimeyer <mail@bastimeyer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new plugin plugin request - approved Plugin meets request requirements and a PR for the plugin will be approved PR: squash commits Commits need to be squashed as a single commit - eg. multiple commits for a single component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants