New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins.vimeo: Fix unable to find configuration URL on some pages #5331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just a quick review of the diff for now. I'll have a look at the whole changes later.
not all the pages contain the URL itself
Those who do however don't have to make additional API queries, so a bit of initialization time when finding streams could be avoided.
Thanks for the feedback. Refactored my changes a bit. Let me know if I understood everything correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./script/test-plugin-urls.py vimeo
-> OK
ignoring the dead video URLs (might be worth replacing them)
Co-authored-by: Sebastian Meyer <mail@bastimeyer.de>
Thanks, @skulblakka |
The current implementation extracts the player configuration URL from the page itself. However it looks like not all the pages contain the URL itself. This PR changes the behaviour to
Let me know if there are any issues (not sure I've used the schema validation correctly).
Tested with some random URLs and seems to work fine:
Resolves #5015.