Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve migration of {g,s}et_plugin_option() #5497

Conversation

bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Aug 14, 2023

  • Add code examples
  • Reword paragraphs
  • Fix missing parenthesis

Ref #5468

I keep getting questions from people who are having trouble understanding the changes, so let's try to improve the docs a bit.


https://deploy-preview-5497--streamlink.netlify.app/migrations#streamlink-g-s-et-plugin-option

- Add code examples
- Reword paragraphs
- Fix missing parenthesis
Copy link
Member

@gravyboat gravyboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and do clarify points. I guess we'll see if it helps clarify for people.

@bastimeyer bastimeyer merged commit 5c7cf4c into streamlink:master Aug 14, 2023
22 checks passed
@bastimeyer bastimeyer deleted the docs/migrations/improve-get-set-plugin-option branch August 14, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants