cli: add --player-env argument #5535
Conversation
- Allow setting custom environment variables for the player process - Keep inherited env vars - Update tests and add `os_environ` global test fixture
There was a problem hiding this comment.
I don't see a benefit to adding this as the use cases are extremely slim and environment variables are easily managed via rc files. If an application is setting a dynamic value for something such as a port (which is already bad behavior on the application's part as typically a default port would be configured via the application's config file) then the application should be setting the environment variable appropriately when the service spins up and the random port is allocated if that port is needed for whatever reason.
That being said as there are no real standards around environment variable usage or expectations and there's little negative impact on Streamlink by adding this. I'll mark it as approved with the caveat that we offer as little support for this feature as possible. People should use wrapper scripts in most situations.
Resolves #5530
This adds the
--player-env KEY=VALUECLI argument, which allows adding environment variables to the spawned player process (on top of the inherited ones). The CLI argument can be repeated for being able to add multiple env vars. As mentioned in #5530, the intended purpose here is to be able to set env vars from the config files.