Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove unneeded pycountry warning filters #5722

Merged

Conversation

bastimeyer
Copy link
Member

Fixed in pycountry 23.12.7:
https://github.com/pycountry/pycountry/blob/23.12.7/HISTORY.txt#L13

Filters were added in #5230, #5393

Setting the min-version requirement of pycountry is not necessary...

@bastimeyer bastimeyer force-pushed the tests/remove-pycountry-warning-filter branch from 94afce6 to 55abd97 Compare December 14, 2023 05:37
@bastimeyer
Copy link
Member Author

https://github.com/pycountry/pycountry/blob/23.12.11/HISTORY.txt#L7

This new UserWarning when a country's official_name is missing is unnecessary, so the second commit will now ignore it.

For example, "Canada" doesn't have an official_name attribute. Streamlink's utils.l10n.Country implementation however has always implemented the name fallback, so the warning is very much unnecessary.

@bastimeyer bastimeyer marked this pull request as ready for review December 14, 2023 05:40
@bastimeyer bastimeyer merged commit bebc2ae into streamlink:master Dec 14, 2023
21 checks passed
@bastimeyer bastimeyer deleted the tests/remove-pycountry-warning-filter branch December 14, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant