utils.args: rewrite module #5778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add typing annotations - Replace `argparse.ArgumentTypeError` with `ValueError` and add missing `ValueError` messages - Simplify `comma_list_filter()` using list comprehension syntax - Update `filesize` - Simplify and fix regex - Use unit/modifier map - Fix zero value check - Rewrite tests
- Strip whitespace at the beginning and set regex anchors - Ignore trailing key name whitespace
- Strip whitespace at the beginning and at the end - Set regex anchors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates and fixes the
streamlink.utils.argsmodule, in preparation for #5715 (which I will rebase and modify after this got merged - after the next release).The first commit keeps the same functionality as the current implementation, apart from different exceptions being raised. The tests have been fully rewritten, but the old tests also pass (ignoring the exception class changes).
The second and third commits fix some issues with the inputs of
filesize()andkeyvalue(). This will affect the--ringbuffer-sizeargument, as well as--http-header,--http-cookie,--http-query-param,--player-env,--twitch-api-headerand--twitch-access-token-param. This is mainly just whitespace character related but it fixes the missing regex anchors.The last commit fixes the incorrect
--ringbuffer-sizehelp text and removes an old and probably unnecessary note.