Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should st.experimental_user.email local value be test@example.com? #7215

Closed
3 of 4 tasks
sfc-gh-jcarroll opened this issue Aug 22, 2023 · 2 comments · Fixed by #7219
Closed
3 of 4 tasks

Should st.experimental_user.email local value be test@example.com? #7215

sfc-gh-jcarroll opened this issue Aug 22, 2023 · 2 comments · Fixed by #7219
Labels
feature:st.user priority:P3 status:needs-triage Has not been triaged by the Streamlit team type:bug Something isn't working

Comments

@sfc-gh-jcarroll
Copy link
Collaborator

Checklist

  • I have searched the existing issues for similar issues.
  • I added a very descriptive title to this issue.
  • I have provided sufficient information below to help reproduce this issue.

Summary

Currently st.experimental_user.email returns test@localhost.com when run locally (cite docs).

However, a more standard and correct approach is to use example.com domain (cite) which is safer.

Should we switch?

Reproducible Code Example

import streamlit as st

st.write(st.experimental_user.email)

Steps To Reproduce

  1. Run the code example in a local environment

Expected Behavior

I see test@example.com which is standard

Current Behavior

I see test@localhost.com, which might not be totally safe and isn't a standard approach.

Is this a regression?

  • Yes, this used to work in a previous version.

Debug info

  • Streamlit version: 1.25
  • Python version: 3.11
  • Operating System: MacOS
  • Browser: Chrome

Additional Information

Thanks @jroes for finding this!

@sfc-gh-jcarroll sfc-gh-jcarroll added type:bug Something isn't working status:needs-triage Has not been triaged by the Streamlit team feature:st.user labels Aug 22, 2023
@github-actions
Copy link

If this issue affects you, please react with a 👍 (thumbs up emoji) to the initial post.

Your feedback helps us prioritize which bugs to investigate and address first.

Visits

@vdonato
Copy link
Collaborator

vdonato commented Aug 23, 2023

Closed by #7219

@vdonato vdonato closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:st.user priority:P3 status:needs-triage Has not been triaged by the Streamlit team type:bug Something isn't working
Projects
None yet
2 participants