SnowflakeConnection.query() retries on errors that will never succeed

[sfc-gh-jcarroll]

Checklist

• I have searched the existing issues for similar issues.
• I added a very descriptive title to this issue.
• I have provided sufficient information below to help reproduce this issue.

Summary

SnowflakeConnection.query() method is intended to refresh the connection and retry for errors that might be transient, such as due to a stale connection.

However the current behavior is to retry on any kind of snowflake.connector.Error including things like SQL syntax errors that will clearly never succeed

Reproducible Code Example

# conn_bug.py
import streamlit as st

conn = st.connection("snowflake")
# SQL syntax error that will never succeed
df = conn.query("SELECT sdgdsgdfds as HIGH_FIVES", ttl=0)
st.dataframe(df)

Steps To Reproduce

1. streamlit run conn_bug.py
2. Observe the app retrying the exception (multiple spinners and multiple stack traces printed

Expected Behavior

The app will attempt the above query once and then return an error

snowflake.connector.errors.ProgrammingError: 000904 (42000): SQL compilation error: error line 1 at position 7
invalid identifier 'SDGDSGDFDS'

Current Behavior

The app attempts the above query 3 times, showing the spinner 3 times and printing the exception stack trace 3 times

Is this a regression?

• Yes, this used to work in a previous version.

Debug info

• Streamlit version: 1.28
• Python version: 3.11
• Operating System: MacOS
• Browser: Chrome

Additional Information

No response

[github-actions]

If this issue affects you, please react with a 👍 (thumbs up emoji) to the initial post.

Your feedback helps us prioritize which bugs to investigate and address first.