New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable https to access external IP #7703
Comments
If it helps, I added a PR that fixes the issue. Let me know if you prefer a different solution, i.e. simply replace the http url by the https one. |
Hey, @LarsHill! I added some commits to your PR (test, fix failing CI etc.), I hope in the next couple of days we could do an internal review! Stay in touch! |
I encountered a similar issue when attempting to deploy it on HuggingFace space. |
@faiztest This change will be released in Sreamlit version 1.29 For now, you can use the streamlit nightly build: pip install streamlit-nightly Hope this would help! |
Checklist
Summary
We try to deploy a streamlit app on a windows server that only allows external connections via https.
When accessing the deployed app, it does not completely load and in the console we repeatedly see the following warning
We identified the root of this warning within this library module:
streamlit/lib/streamlit/net_util.py
Line 32 in 018f49f
Apparently the hardcoded url
is called to retrieve the external IP of the server.
Since we can only access urls via https, the streamlit app does not continue loading.
Since "https://checkip.amazonaws.com" (using https) works as well, it would be great if a fallback would be implemented to try getting the ip via https when the http response is None.
Thanks and best regards
Lars
Reproducible Code Example
No response
Steps To Reproduce
No response
Expected Behavior
No response
Current Behavior
No response
Is this a regression?
Debug info
Additional Information
No response
The text was updated successfully, but these errors were encountered: