Keys can also be ints #3697
Merged
Keys can also be ints #3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhuang1997
approved these changes
Aug 11, 2021
kajarenc
approved these changes
Aug 11, 2021
tconkling
added a commit
that referenced
this pull request
Aug 23, 2021
* develop: (33 commits) Up version to 0.87.0 (#3721) Adds static embedded apps for st.metric to docs (#3725) Add metric docs and fix urls Keys can also be ints (#3697) change config message clean up server in test add test endpoit created conditionally add test endpoit created conditionally increase timeout for tests add note that the script check is experimental add timeout test fix tests rename variable rename variable -run the script endpoint async; change config to expose the script check using flag; -run the script endpoint async; change config to expose the script check using flag; ensure event base file watcher is clean before running tests filter streamlit internal state keys filter streamlit internal state keys fix formatting ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people use ints for keys, and it is easy enough to support, so this updates the type annotations and docs to allow it, and ensures int keys are converted to strings so we can still rely on that internally