Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix&Improve Kubernetes dashboards #91

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Fix&Improve Kubernetes dashboards #91

merged 3 commits into from
Jan 18, 2023

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Jan 17, 2023

  1. Containers Metrics dashboard
    • allow custom app label
    • some labels of advisor metrics changed(pod_name->pod, container_name->container) since k8s 1.16: ref
  2. Add ZooKeeper-3.6 dashboard

@ciiiii ciiiii requested a review from a team as a code owner January 17, 2023 16:08
ericsyh
ericsyh approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@ericsyh ericsyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciiiii ciiiii merged commit 750290f into master Jan 18, 2023
@ciiiii ciiiii deleted the yscai/kubernetes-dashboards branch January 18, 2023 16:17
@ciiiii ciiiii mentioned this pull request Feb 22, 2023
Merged
4 tasks
ericsyh pushed a commit that referenced this pull request Jul 25, 2023
@ciiiii @ericsyh
Fix&Improve Kubernetes dashboards (#91)
5da6065 
* Add zk3.6 dashboard for kubernetes

* Update cadvisor metrics labels

* Improve templating to allow custom app label

(cherry picked from commit 750290f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuteng tuteng tuteng approved these changes

@ericsyh ericsyh ericsyh approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui codelipenghui is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciiiii @tuteng @ericsyh