Fallback to Helm .Release.Namespace when .namespace not defined

[enriched]

This defaults the pulsar namespace to helms default .Release.Namespace if namespace is not defined. This is implemented in the new "pulsar.namespace" template.

The .namespace is set to "pulsar" in the default values.yaml, in order to unset it --set namespace=null can be passed to the helm install command.

closes #100

[sijie]

@enriched great contribution!

[austince]

Hey, thanks for this contribution! Please correct me if I'm wrong, but I think it might have missed a few instances in some of the .tpl files:

charts/charts/pulsar/templates/zookeeper/_zookeeper.tpl

Lines 23 to 25 in 58b0b8b

	{{- define "pulsar.zookeeper.hostname" -}}
	${HOSTNAME}.{{ template "pulsar.zookeeper.service" . }}.{{ .Values.namespace }}.svc.cluster.local
	{{- end -}}

I've found reference to the direct .namespace value in the following directory's _{dir}.tpl

• autorecovery
• bookkeeper
• broker
• pulsar_manager
• toolset
• zookeeper

Should I open up a new issue for this?

[enriched]

@austince I think you're right, thanks for catching that! If you could open a new issue that would be great.