Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a separate setting for domain suffix #108

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Add a separate setting for domain suffix #108

merged 3 commits into from
Jul 2, 2020

Conversation

sijie
Copy link
Member

@sijie sijie commented Jun 29, 2020

No description provided.

@sijie
Don't substitute environment variables
2d53014 
*Motivation*

environment variables are already taken by bash scripts. We don't need to substitute them.
@sijie
Add a separate setting for domain suffix
146c183 
*Motivation*

domain_filter is used for external-dns for finding the hosted DNS zones.
It should not be used for domain suffix directly.

Additionly, this pull request also fixes the following:

- Fix gc service account settings.
- Don't subsitute the environment variable files.
@sijie sijie added this to the 1.3.0 milestone Jun 29, 2020
@sijie sijie requested review from wolfstudy and a team June 29, 2020 00:03
@sijie sijie self-assigned this Jun 29, 2020
@wolfstudy
Copy link
Contributor

wolfstudy commented Jun 29, 2020 •
edited

The changes LGTM, @sijie please fix ci error

$ helm lint charts/pulsar

==> Linting charts/pulsar
[ERROR] templates/: template: pulsar/templates/pulsar-manager/pulsar-manager-statefulset.yaml:48:28: executing "pulsar/templates/pulsar-manager/pulsar-manager-statefulset.yaml" at <include (print $.Template.BasePath "/pulsar-manager/pulsar-manager-configmap.yaml") .>: error calling include: template: pulsar/templates/control-center/_control_center.tpl:9:46: executing "pulsar.control_center_domain" at <.Values.domain.suffix>: nil pointer evaluating interface {}.suffix

Error: 1 chart(s) linted, 1 chart(s) failed

wolfstudy
wolfstudy approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit d03394e into master Jul 2, 2020
@wolfstudy wolfstudy deleted the dont_substitute_env_vars branch July 2, 2020 06:16
@jonaskint jonaskint mentioned this pull request Jul 2, 2020
Closed
jonaskint added a commit to jonaskint/streamnative-charts that referenced this pull request Jul 2, 2020
@jonaskint
Bumping helm chart to 1.2.1 to roll out streamnative#108
b1cd786
sijie pushed a commit that referenced this pull request Jul 2, 2020
@jonaskint
Bumping helm chart to 1.2.1 to roll out #108 (#110)
b4da3be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

Assignees

@sijie sijie

Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sijie @wolfstudy