fix: generate secret from json string #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerbitx
previously approved these changes
Aug 18, 2023
|
@FushuWang pls help update the slim chart https://github.com/streamnative/charts/blob/master/charts/sn-platform-slim/templates/broker/broker-secret.yaml#L23 |
|
@tuteng PTAL |
tuteng
approved these changes
Aug 22, 2023
ericsyh
pushed a commit
that referenced
this pull request
Aug 24, 2023
* fix: generate secret from json string * fix: generate secret from json string for sn-platform-slim (cherry picked from commit 62a1df3)
ericsyh
pushed a commit
that referenced
this pull request
Aug 24, 2023
* fix: generate secret from json string * fix: generate secret from json string for sn-platform-slim (cherry picked from commit 62a1df3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The content that decodes from the secret is not correct, because it has backslashes.
"{\"client_id\":\"b097d864-4b4d-0020-a34e-0929dkjslkj29\",\"client_secret\":\"XFXXXXXXX_51ZijnihaoVqGJbbzk\"}"The correct format should be like this
{"client_id":"b097d864-4b4d-0020-a34e-0929dkjslkj29","client_secret":"XFXXXXXXX_51ZijnihaoVqGJbbzk"}Modifications
Use the
fromYamlfirst before thetoJson.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)