Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the backup can run when zookeeper reconfig enabled #1143

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

zymap
Copy link
Member

@zymap zymap commented Feb 6, 2024

Motivation

Make the backup can run when zookeeper reconfig enabled

@zymap zymap requested review from a team as code owners February 6, 2024 13:44
Copy link

github-actions bot commented Feb 6, 2024

@zymap:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Feb 6, 2024
ericsyh
ericsyh previously approved these changes Mar 7, 2024
@ericsyh ericsyh self-requested a review March 7, 2024 07:22
ericsyh
ericsyh previously approved these changes Mar 7, 2024
Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
@ericsyh ericsyh merged commit 023056b into master Mar 7, 2024
2 checks passed
@ericsyh ericsyh deleted the yong/imporve-backup-to-support-reconfig branch March 7, 2024 07:39
ericsyh pushed a commit that referenced this pull request Mar 11, 2024
* Make the backup can run when zookeeper reconfig enabled

* Apply change to the platform slim

* fix chart lint

Signed-off-by: ericsyh <ericshenyuhao@outlook.com>

* fix chart lint

Signed-off-by: ericsyh <ericshenyuhao@outlook.com>

---------

Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
Co-authored-by: Eric Shen <ericshenyuhao@outlook.com>
(cherry picked from commit 023056b)
ericsyh pushed a commit that referenced this pull request Mar 11, 2024
* Make the backup can run when zookeeper reconfig enabled

* Apply change to the platform slim

* fix chart lint

Signed-off-by: ericsyh <ericshenyuhao@outlook.com>

* fix chart lint

Signed-off-by: ericsyh <ericshenyuhao@outlook.com>

---------

Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
Co-authored-by: Eric Shen <ericshenyuhao@outlook.com>
(cherry picked from commit 023056b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants