Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to fix operator security vulnerabilities #371

Closed
2 of 5 tasks
tpiperatgod opened this issue May 19, 2022 · 17 comments
Closed
2 of 5 tasks

need to fix operator security vulnerabilities #371

tpiperatgod opened this issue May 19, 2022 · 17 comments

Comments

@tpiperatgod
Copy link
Contributor

tpiperatgod commented May 19, 2022

The function-mesh-operator has some security vulnerabilities, and we need to fix them, refer to:

https://artifacthub.io/packages/helm/function-mesh/function-mesh-operator?modal=security-report

@hpvd
Copy link

hpvd commented Aug 2, 2022

Following link provided above,
today in v0.4:
10 vulnerabilities have been detected in this package's images.
2022-08-02_15h04_48

@hpvd
Copy link

hpvd commented Aug 15, 2022

in link above to redhat, the redhat security score of A unfortunately has no real meaningfulness for the total security:

This image includes layers and packages that cannot be scanned or compared to public vulnerability information.

The Container Health Index analysis is based on RPM packages signed and created by Red Hat, and does not grade other software that may be included in a container image.

2022-08-15_14h06_53

@hpvd
Copy link

hpvd commented Aug 15, 2022

of course its hard to fix all of them...

what do you think of adapting the distroless approach to get rid of software in containers that contains security problems but is actually not needed anyway?

@hpvd
Copy link

hpvd commented Aug 15, 2022

just opened a new issue with some background and sources on the distroless approach:
#448

@hpvd
Copy link

hpvd commented Sep 30, 2022

today in v0.6:
with https://artifacthub.io/packages/helm/function-mesh/function-mesh-operator?modal=security-report

13 vulnerabilities have been detected in this package's images.

2022-09-30_13h27_13

@hpvd
Copy link

hpvd commented Oct 18, 2022

just an update on freshly release v0.7:
14 vulnerabilities (14 fixable) have been detected in this package's images.

source: https://artifacthub.io/packages/helm/function-mesh/function-mesh-operator?modal=security-report

2022-10-18_07h56_29

@hpvd
Copy link

hpvd commented Oct 18, 2022

some more details:
2022-10-18_07h57_27

@hpvd
Copy link

hpvd commented Oct 18, 2022

As background info, the security scanner used by artifacthub, providing results shown above
is trivy, so all the finding should be pretty valid.

For details, see:
https://artifacthub.io/docs/topics/security_report/

and trivy
https://github.com/aquasecurity/trivy

@hpvd
Copy link

hpvd commented Oct 18, 2022

there is also an easy to use github action for scanning with trivy

  • the complete repository,
  • pull requests,
  • docker container
  • IaC
  • etc.

=> Maybe, this is interesting to integrate this directly into the CI pipeline...
See Readme of https://github.com/aquasecurity/trivy-action

@hpvd
Copy link

hpvd commented Nov 17, 2022

fyi - a CRITICAL vulnerability was newly introduced with the release v0.8
by using an old version of https://github.com/emicklei/go-restful/tags
2.9.5 from May 16, 2019
latest would be v2.16.0 or even 3.10.0

Some others were nicely cleaned up by updating dependencies!

in summary, this leads to a security rating of F (where A is the best)

for details
2022-11-17_12h23_05

https://artifacthub.io/packages/helm/function-mesh/function-mesh-operator?modal=security-report

@jiangpengcheng
Copy link
Member

hm, that looks bad, I will add workflow to scan the vulnerabilities

@hpvd
Copy link

hpvd commented Nov 18, 2022

for further thoughts on this topic see #527 (comment)

@hpvd
Copy link

hpvd commented Nov 18, 2022

looks like they may be introduce by metrics server which has an open issue for this
kubernetes-sigs/metrics-server#1096

or by kube metrics, where a new version was just released (v2.7)
https://github.com/kubernetes/kube-state-metrics/releases
(current rating: A - No vulnerabilities found)

@jiangpengcheng
Copy link
Member

closing as resolved

@hpvd
Copy link

hpvd commented Dec 22, 2022

perfectly solved:

security rating: A
see
2022-12-22_18h23_37

https://artifacthub.io/packages/helm/function-mesh/function-mesh-operator?modal=security-report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants