Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update unmodifiable fields for StatefulSet #639

Merged

Conversation

jiangpengcheng
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #638

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

StatefulSet.spec only allow to update below fields:

  • replicas
  • template
  • updateStrategy
  • persistentVolumeClaimRetentionPolicy
  • minReadySeconds

while during version upgrade of FM, Selector field is changed even with same yaml, and other fields maybe changed in further development too, such as:

  • PodManagementPolicy
  • ServiceName
  • VolumeClaimTemplates

we need to ensure these changed won't update old existing statefulset

Modifications

Do not update unmodifiable fields for StatefulSet

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners May 11, 2023 03:37
@github-actions github-actions bot added the doc-required This pr needs a document label May 11, 2023
@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature m/2023-05 labels May 16, 2023
@freeznet freeznet merged commit 93b5e06 into streamnative:master May 16, 2023
15 checks passed
@Huanli-Meng Huanli-Meng added doc-added and removed doc-required This pr needs a document labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-added m/2023-05 type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backward compatibility issue
4 participants