Fix yaml format log config #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangpengcheng
requested review from
nlu90,
freeznet and
a team
as code owners
jiangpengcheng
commented
Aug 18, 2023
| @@ -1072,7 +1072,7 @@ func getProcessJavaRuntimeArgs(name, packageName, clusterName, logLevel, details | |||
| state *v1alpha1.Stateful, | |||
| tlsConfig TLSConfig, authConfig *v1alpha1.AuthConfig, | |||
| maxPendingAsyncRequests *int32, logConfigFileName string) []string { | |||
| classPath := "/pulsar/instances/java-instance.jar" | |||
| classPath := "/pulsar/instances/java-instance.jar:/pulsar/lib/*" | |||
There was a problem hiding this comment.
log4j yaml extensions requires some additional lib such as com.fasterxml.jackson.core-jackson-databind-2.13.2.1.jar and com.fasterxml.jackson.dataformat-jackson-dataformat-yaml-2.13.2.jar
if there is no such libs in classpath, it cannot read yaml format config and there will be error when use yaml format config file:
file:///pulsar/conf/java-log/java_instance_log4j.yaml; lineNumber: 1; columnNumber: 1; Content
is not allowed in prolog.*
jiangpengcheng
commented
Aug 18, 2023
| {{ else }} | ||
| TimeBasedTriggeringPolicy: | ||
| interval: 1 | ||
| modulate: true | ||
| SizeBasedTriggeringPolicy: | ||
| size: "10MB" | ||
| CronTriggeringPolicy: |
There was a problem hiding this comment.
don't need CronTriggeringPolicy since we have a TimeBasedTriggeringPolicy
jiangpengcheng
commented
Aug 18, 2023
freeznet
previously approved these changes
Aug 18, 2023
freeznet
approved these changes
Aug 21, 2023
nlu90
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #680
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)