Add exit_on_oom=true #744
Merged
Add exit_on_oom=true #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
| @@ -1,5 +1,5 @@ | |||
| # Current Operator version | |||
| VERSION ?= 0.20.0 | |||
There was a problem hiding this comment.
this should only be updated when do release
There was a problem hiding this comment.
why would we not want to release this?
There was a problem hiding this comment.
also, the version on master is incorrect anyways, there is a v0.20.1 release on dockerhub already
yuweisung
reviewed
Apr 25, 2024
freeznet
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Exit the client when it is OOM Killed.
Modifications
Add
-Dpulsar.allocator.exit_on_oom=trueto common.goVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Need to update docs?
no-need-docInternals change resolving a bug.