Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[BUG] Integrations tests not working on OSX #90

Closed
PierreZ opened this issue Feb 7, 2020 · 1 comment
Closed

[BUG] Integrations tests not working on OSX #90

PierreZ opened this issue Feb 7, 2020 · 1 comment
Labels

Comments

@PierreZ
Copy link
Contributor

PierreZ commented Feb 7, 2020

Describe the bug
Integrations tests are failing on OSX

To Reproduce
Steps to reproduce the behavior:

  1. use OSX
  2. mvn clean test
error Error: connect ECONNREFUSED 127.0.0.1:15014
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1137:16) {
  errno: -111,
  code: ‘ECONNREFUSED’,
  syscall: ‘connect’,
  address: ‘127.0.0.1’,
  port: 15014
}
ExitCode=1

Expected behavior
Should not fail

Additional context
We are running containers in host mode, which means that port should be available in both side. Kop broker is started in host, tests in Docker containers.

While is it working on linux as we have no vms, on OSX, testcontainers is forcing us to use the host.testcontainers.internal host to communicate with the host. Which is creating problem as we cannot easily advertize this adress.

Proposal

In order to quickly merge integrations tests with those in apache pulsar, I think we should be more close to what is done in apache/pulsar. We could:

  • bump Pulsar's version in testcontainers to directly rely on the official PulsarContainer object,
  • Make PulsarContainer the de-facto way to test proto handlers by making them first-class citizen,
  • revamp IntegrationsTest to use PulsarContainer with KoP.

What do you think?

@jiazhai
Copy link
Contributor

jiazhai commented Feb 9, 2020

@PierreZ Thanks for the help on this issue. It contains so detailed information 👍. +1 on the proposal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants