This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[bugfix] Fix memory leak in case of closed connections with pending requests #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested review from
BewareMyPower and
Demogorgon314
as code owners
BewareMyPower
previously approved these changes
Dec 13, 2022
eolivelli
dismissed stale reviews from michaeljmarshall, BewareMyPower, and lhotari
via
6747d3c
eolivelli
force-pushed
the
impl/mem-leak-close-connection
branch
from
6747d3c
to
4d186d4
Compare
michaeljmarshall
approved these changes
Dec 16, 2022
BewareMyPower
approved these changes
Dec 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #1626 +/- ##
============================================
- Coverage 15.77% 15.76% -0.02%
Complexity 612 612
============================================
Files 164 164
Lines 12249 12251 +2
Branches 1124 1124
============================================
- Hits 1932 1931 -1
- Misses 10158 10161 +3
Partials 159 159
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a connection is closed while having pending requests, the ByteBuf is not released.
Modifications
Release the ByteBuf attached to the original request
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-docdoc(If this PR contains doc changes)