This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[bugfix] Fix NPE in PendingTopicFutures and fix KafkaMessageOrderTestBase #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested review from
BewareMyPower and
Demogorgon314
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
============================================
+ Coverage 15.75% 15.76% +0.01%
- Complexity 612 613 +1
============================================
Files 164 164
Lines 12262 12265 +3
Branches 1124 1124
============================================
+ Hits 1932 1934 +2
- Misses 10171 10172 +1
Partials 159 159
|
BewareMyPower
approved these changes
Feb 13, 2023
Demogorgon314
pushed a commit
that referenced
this pull request
Feb 14, 2023
…Base (#1722) Fixes #1629 This is a backport of this patch in S4K (Starlight for Kafka) datastax/starlight-for-kafka#58 ### Motivation There is a race condition when two threads try to access the same topic. ### Modifications Fix the handling of concurrency in PendingTopicFutures. Fix the KafkaMessageOrderTestBase (cherry picked from commit 2386e8b)
Demogorgon314
pushed a commit
that referenced
this pull request
Feb 22, 2023
…Base (#1722) Fixes #1629 This is a backport of this patch in S4K (Starlight for Kafka) datastax/starlight-for-kafka#58 ### Motivation There is a race condition when two threads try to access the same topic. ### Modifications Fix the handling of concurrency in PendingTopicFutures. Fix the KafkaMessageOrderTestBase (cherry picked from commit 2386e8b)
Demogorgon314
pushed a commit
that referenced
this pull request
Feb 27, 2023
…Base (#1722) Fixes #1629 This is a backport of this patch in S4K (Starlight for Kafka) datastax/starlight-for-kafka#58 ### Motivation There is a race condition when two threads try to access the same topic. ### Modifications Fix the handling of concurrency in PendingTopicFutures. Fix the KafkaMessageOrderTestBase (cherry picked from commit 2386e8b)
eolivelli
added a commit
to eolivelli/kop
that referenced
this pull request
Feb 28, 2023
…Base (streamnative#1722) Fixes streamnative#1629 This is a backport of this patch in S4K (Starlight for Kafka) datastax/starlight-for-kafka#58 ### Motivation There is a race condition when two threads try to access the same topic. ### Modifications Fix the handling of concurrency in PendingTopicFutures. Fix the KafkaMessageOrderTestBase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1629
This is a backport of this patch in S4K (Starlight for Kafka)
datastax/starlight-for-kafka#58
Motivation
There is a race condition when two threads try to access the same topic.
Modifications
Fix the handling of concurrency in PendingTopicFutures.
Fix the KafkaMessageOrderTestBase
Verifying this change
This change is already covered by existing tests and added new tests
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)