This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[improve] Add message.max.bytes for describe broker config #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1776 +/- ##
============================================
- Coverage 16.05% 16.02% -0.04%
Complexity 626 626
============================================
Files 165 165
Lines 12311 12336 +25
Branches 1128 1128
============================================
Hits 1977 1977
- Misses 10171 10196 +25
Partials 163 163
|
BewareMyPower
approved these changes
Mar 23, 2023
BewareMyPower
pushed a commit
that referenced
this pull request
Mar 28, 2023
### Motivation Some of the Producer requires the `message.max.bytes` configuration. ``` Error: [CDC:ErrKafkaNewSaramaProducer]new sarama producer: [CDC:ErrKafkaBrokerConfigNotFound]cannot find the `message.max.bytes` from the broker's configuration ``` ### Modifications * Add `message.max.bytes` for describe broker config. The config is reused pulsar config. (cherry picked from commit 92285f1)
Demogorgon314
added a commit
that referenced
this pull request
Apr 4, 2023
### Motivation Some of the Producer requires the `message.max.bytes` configuration. ``` Error: [CDC:ErrKafkaNewSaramaProducer]new sarama producer: [CDC:ErrKafkaBrokerConfigNotFound]cannot find the `message.max.bytes` from the broker's configuration ``` ### Modifications * Add `message.max.bytes` for describe broker config. The config is reused pulsar config. (cherry picked from commit 92285f1)
Demogorgon314
added a commit
that referenced
this pull request
Apr 6, 2023
### Motivation Some of the Producer requires the `message.max.bytes` configuration. ``` Error: [CDC:ErrKafkaNewSaramaProducer]new sarama producer: [CDC:ErrKafkaBrokerConfigNotFound]cannot find the `message.max.bytes` from the broker's configuration ``` ### Modifications * Add `message.max.bytes` for describe broker config. The config is reused pulsar config. (cherry picked from commit 92285f1)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the Producer requires the
message.max.bytesconfiguration.Modifications
message.max.bytesfor describe broker config. The config is reused pulsar config.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)