This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Support passing the token directly as the password for Schema Registry #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation Currently, when authentication is enabled, we have to pass `token:<token>` as the password in the `basic.auth.user.info` config. However, some clients don't allow a colon appearing in the password. See https://github.com/confluentinc/confluent-kafka-python/blob/f3055be4d2aa18ffc833cc88f7b08b173d4da433/src/confluent_kafka/schema_registry/schema_registry_client.py#L108-L111 ### Modifications - Support passing the token directly, i.e. without the "token:" prefix, as the password - Add the document to describe how to configure the authentication for Schema Registry
BewareMyPower
added
the
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
============================================
- Coverage 16.02% 15.99% -0.03%
+ Complexity 626 625 -1
============================================
Files 165 165
Lines 12336 12333 -3
Branches 1128 1128
============================================
- Hits 1977 1973 -4
Misses 10196 10196
- Partials 163 164 +1
|
Demogorgon314
approved these changes
Mar 31, 2023
BewareMyPower
added a commit
that referenced
this pull request
Apr 2, 2023
#1784) ### Motivation Currently, when authentication is enabled, we have to pass `token:<token>` as the password in the `basic.auth.user.info` config. However, some clients don't allow a colon appearing in the password. See https://github.com/confluentinc/confluent-kafka-python/blob/f3055be4d2aa18ffc833cc88f7b08b173d4da433/src/confluent_kafka/schema_registry/schema_registry_client.py#L108-L111 ### Modifications - Support passing the token directly, i.e. without the "token:" prefix, as the password - Add the document to describe how to configure the authentication for Schema Registry (cherry picked from commit a210d7b)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when authentication is enabled, we have to pass
token:<token>as the password in thebasic.auth.user.infoconfig. However, some clients don't allow a colon appearing in the password.See
https://github.com/confluentinc/confluent-kafka-python/blob/f3055be4d2aa18ffc833cc88f7b08b173d4da433/src/confluent_kafka/schema_registry/schema_registry_client.py#L108-L111
Modifications
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)