This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[test] Add kafka admin api unit test #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1793 +/- ##
=========================================
Coverage 16.02% 16.03%
Complexity 626 626
=========================================
Files 165 165
Lines 12336 12333 -3
Branches 1128 1128
=========================================
Hits 1977 1977
+ Misses 10196 10193 -3
Partials 163 163
|
BewareMyPower
approved these changes
Apr 18, 2023
BewareMyPower
pushed a commit
that referenced
this pull request
Apr 24, 2023
### Motivation Please don't use the admin APIs, and it is hard to support in KoP. | Method | Is Support | |------------------------------|-------------------------------------------------| | createAcls | Don't support, use pulsar admin to manage acl. | | deleteAcls | Don't support, use pulsar admin to manage acl. | | describeAcls | Don't support, use pulsar admin to manage acl. | | listAcls | Don't support, use pulsar admin to manage acl. | | electLeaders | Don't support, it depends on the pulsar. | | describeUserScramCredentials | Don't support | | alterUserScramCredentials | Don't support | | alterPartitionReassignments | Don't support | | listPartitionReassignments | Don't support | | describeDelegationToken | Don't support | | createDelegationToken | Don't support | | alterReplicaLogDirs | Don't support | | describeReplicaLogDirs | Don't support | | describeLogDirs | Don't support | Can be supported in feature. | Method | How to support. | |------------------------------|------------------------------------------------| | alterClientQuotas | Can use pulsar admin handle it. | | describeClientQuotas | Can get it from pulsar admin. | | deleteConsumerGroupOffsets | Can handle by group coordinator. | | alterConfigs | Maybe can store in the metadata store. | | incrementalAlterConfigs | Maybe can store in the metadata store. | ### Modifications * Add kafka admin api unit test. ### Documentation Check the box below. Need to update docs? - [ ] `doc-required` (If you need help on updating docs, create a doc issue) - [x] `no-need-doc` (Please explain why) - [ ] `doc` (If this PR contains doc changes) (cherry picked from commit f0eda8e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Please don't use the admin APIs, and it is hard to support in KoP.
Can be supported in feature.
Modifications
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)