Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Conversation

Demogorgon314
Copy link
Member

Cherry-pick #1837

### Motivation

The CLI needs to check the current committed topic’s name before
resetting. But in KoP it will transfer to a short topic name.

https://github.com/apache/kafka/blob/d46c3f259cce25c43f20fba3943d5cb34ed909ea/core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala#L818-L820

```
bin/kafka-consumer-groups.sh --bootstrap-server localhost:9092  --group kop/s1 --topic public/default/p3:0 --reset-offsets --shift-by -10 --execute
Cannot shift offset for partition public/default/p3-0 since there is no current committed offset
```
<img width="1120" alt="image"
src="https://user-images.githubusercontent.com/22697570/236761387-c06930c1-3072-43b2-84cb-7e16f2504999.png">

### Modifications

Return full name when list consumer group offsets.

(cherry picked from commit e58b7b9)
@Demogorgon314 Demogorgon314 self-assigned this May 12, 2023
@Demogorgon314 Demogorgon314 marked this pull request as ready for review May 12, 2023 08:55
@Demogorgon314 Demogorgon314 merged commit 144f00c into streamnative:branch-2.10.4 May 12, 2023
3 checks passed
@Demogorgon314 Demogorgon314 deleted the Demogorgon314/unify-fetch-offset-topic-name-branch-2.10.4 branch May 23, 2023 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants