This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[bugfix][transactions] Release memory in TransactionMarkerChannelHandler #1867
Merged
BewareMyPower
merged 1 commit into
streamnative:master
from
Demogorgon314:transaction/release-memory-in-transaction-marker-channel-handler
Jun 1, 2023
Merged
[bugfix][transactions] Release memory in TransactionMarkerChannelHandler #1867
BewareMyPower
merged 1 commit into
streamnative:master
from
Demogorgon314:transaction/release-memory-in-transaction-marker-channel-handler
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@eolivelli Please help review this PR, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1867 +/- ##
============================================
+ Coverage 18.72% 18.77% +0.04%
Complexity 743 743
============================================
Files 184 184
Lines 13276 13290 +14
Branches 1208 1210 +2
============================================
+ Hits 2486 2495 +9
- Misses 10611 10614 +3
- Partials 179 181 +2
|
gaoran10
approved these changes
May 31, 2023
eolivelli
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eolivelli
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eolivelli
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we need to add the |
BewareMyPower
approved these changes
Jun 1, 2023
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Aug 14, 2023
…ler (streamnative#1867) ### Motivation Release memory in TransactionMarkerChannelHandler Co-authored-by: Enrico Olivelli <enrico.olivelli@datastax.com> (cherry picked from commit 60990bc)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cherry-picked/branch-2.10.4
cherry-picked/branch-2.11
cherry-picked/branch-3.0
no-need-doc
This pr does not need any document
release/2.10.4
release/2.11
release/3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Release memory in TransactionMarkerChannelHandler
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)