Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Conversation

Demogorgon314
Copy link
Member

Motivation

Prevent ConcurrentModificationException in getProducer()

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@Demogorgon314 Demogorgon314 self-assigned this May 30, 2023
@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 30, 2023
@Demogorgon314
Copy link
Member Author

@eolivelli Please help review this PR, thanks!

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #1868 (675f0dd) into master (0d2ed74) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1868      +/-   ##
============================================
+ Coverage     18.72%   18.77%   +0.05%     
  Complexity      743      743              
============================================
  Files           184      184              
  Lines         13276    13288      +12     
  Branches       1208     1210       +2     
============================================
+ Hits           2486     2495       +9     
- Misses        10611    10612       +1     
- Partials        179      181       +2     
Impacted Files Coverage Δ
...ordinator/transaction/TransactionStateManager.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case could the ConcurrentModificationException happen?

@Demogorgon314
Copy link
Member Author

In which case could the ConcurrentModificationException happen?
@BewareMyPower
The shutdown method and getProducer method might cause concurrent modification, right?

@BewareMyPower BewareMyPower merged commit 14f4f05 into streamnative:master May 31, 2023
8 of 9 checks passed
@Demogorgon314 Demogorgon314 deleted the transaction/Prevent_ConcurrentModificationException_in_getProducer branch May 31, 2023 02:28
BewareMyPower pushed a commit that referenced this pull request Jun 14, 2023
…Producer() (#1868)

### Motivation

Prevent ConcurrentModificationException in getProducer()

Co-authored-by: Enrico Olivelli <enrico.olivelli@datastax.com>
(cherry picked from commit 14f4f05)
BewareMyPower pushed a commit that referenced this pull request Jun 29, 2023
…Producer() (#1868)

### Motivation

Prevent ConcurrentModificationException in getProducer()

Co-authored-by: Enrico Olivelli <enrico.olivelli@datastax.com>
(cherry picked from commit 14f4f05)
Demogorgon314 added a commit to Demogorgon314/kop that referenced this pull request Aug 14, 2023
…Producer() (streamnative#1868)

### Motivation

Prevent ConcurrentModificationException in getProducer()

Co-authored-by: Enrico Olivelli <enrico.olivelli@datastax.com>
(cherry picked from commit 14f4f05)
Demogorgon314 added a commit to Demogorgon314/kop that referenced this pull request Nov 28, 2023
…Producer() (streamnative#1868)

### Motivation

Prevent ConcurrentModificationException in getProducer()

Co-authored-by: Enrico Olivelli <enrico.olivelli@datastax.com>
(cherry picked from commit 14f4f05)
(cherry picked from commit 1aaa541)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants