This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[bugfix][transactions] Make TxnTransitMetadata.topicPartitions immutable #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in/java/io/streamnative/pulsar/handlers/kop/coordinator/transaction/TransactionMetadata.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
============================================
+ Coverage 18.72% 18.78% +0.05%
Complexity 743 743
============================================
Files 184 184
Lines 13276 13285 +9
Branches 1208 1210 +2
============================================
+ Hits 2486 2495 +9
+ Misses 10611 10609 -2
- Partials 179 181 +2
|
BewareMyPower
approved these changes
May 31, 2023
gaoran10
approved these changes
May 31, 2023
Demogorgon314
added a commit
to Demogorgon314/starlight-for-kafka
that referenced
this pull request
Jun 1, 2023
BewareMyPower
pushed a commit
that referenced
this pull request
Jun 14, 2023
…ble (#1869) ### Motivation https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala#L190 The `TxnTransitMetadata.topicPartitions` should be immutable. Otherwise, it will cause race conditions. ### Modifications Make `TxnTransitMetadata.topicPartitions` immutable (cherry picked from commit 328107e)
BewareMyPower
pushed a commit
that referenced
this pull request
Jun 29, 2023
…ble (#1869) ### Motivation https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala#L190 The `TxnTransitMetadata.topicPartitions` should be immutable. Otherwise, it will cause race conditions. ### Modifications Make `TxnTransitMetadata.topicPartitions` immutable (cherry picked from commit 328107e)
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Aug 14, 2023
…ble (streamnative#1869) ### Motivation https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala#L190 The `TxnTransitMetadata.topicPartitions` should be immutable. Otherwise, it will cause race conditions. ### Modifications Make `TxnTransitMetadata.topicPartitions` immutable (cherry picked from commit 328107e)
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Nov 28, 2023
…ble (streamnative#1869) ### Motivation https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala#L190 The `TxnTransitMetadata.topicPartitions` should be immutable. Otherwise, it will cause race conditions. ### Modifications Make `TxnTransitMetadata.topicPartitions` immutable (cherry picked from commit 328107e) (cherry picked from commit 08772d4)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala#L190
The
TxnTransitMetadata.topicPartitionsshould be immutable, otherwise it will cause race conditions.Modifications
Make TxnTransitMetadata.topicPartitions immutable
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)