This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[improvement] hide scary InterruptedException in KopEventManager during broker shutdown #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng broker shutdown
BewareMyPower
approved these changes
Jun 1, 2023
wenbingshen
approved these changes
Jun 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #1874 +/- ##
============================================
+ Coverage 18.72% 18.75% +0.02%
+ Complexity 743 742 -1
============================================
Files 184 184
Lines 13276 13287 +11
Branches 1208 1210 +2
============================================
+ Hits 2486 2492 +6
- Misses 10611 10613 +2
- Partials 179 182 +3
|
Demogorgon314
deleted the
s4k/hide_scary_InterruptedException_in_KopEventManager_during_broker_shutdown
branch
BewareMyPower
pushed a commit
that referenced
this pull request
Jun 14, 2023
…ng broker shutdown (#1874) ### Motivation The following error log is useless, we can change it to debug level. ``` 2023-05-31T04:10:01,281+0000 [kop-event-thread] ERROR io.streamnative.pulsar.handlers.kop.KopEventManager - Error processing event null java.lang.InterruptedException: null at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1638) ~[?:?] at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:435) ~[?:?] at io.streamnative.pulsar.handlers.kop.KopEventManager$KopEventThread.doWork(KopEventManager.java:140) ~[ewqichUs9Q6h6lSbSYgTKg/:?] at io.streamnative.pulsar.handlers.kop.utils.ShutdownableThread.run(ShutdownableThread.java:108) ~[ewqichUs9Q6h6lSbSYgTKg/:?] ``` ### Modifications * Hide scary `InterruptedException` in KopEventManager during broker shutdown (cherry picked from commit 5bf2416)
BewareMyPower
pushed a commit
that referenced
this pull request
Jun 29, 2023
…ng broker shutdown (#1874) ### Motivation The following error log is useless, we can change it to debug level. ``` 2023-05-31T04:10:01,281+0000 [kop-event-thread] ERROR io.streamnative.pulsar.handlers.kop.KopEventManager - Error processing event null java.lang.InterruptedException: null at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1638) ~[?:?] at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:435) ~[?:?] at io.streamnative.pulsar.handlers.kop.KopEventManager$KopEventThread.doWork(KopEventManager.java:140) ~[ewqichUs9Q6h6lSbSYgTKg/:?] at io.streamnative.pulsar.handlers.kop.utils.ShutdownableThread.run(ShutdownableThread.java:108) ~[ewqichUs9Q6h6lSbSYgTKg/:?] ``` ### Modifications * Hide scary `InterruptedException` in KopEventManager during broker shutdown (cherry picked from commit 5bf2416)
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Aug 14, 2023
…ng broker shutdown (streamnative#1874) ### Motivation The following error log is useless, we can change it to debug level. ``` 2023-05-31T04:10:01,281+0000 [kop-event-thread] ERROR io.streamnative.pulsar.handlers.kop.KopEventManager - Error processing event null java.lang.InterruptedException: null at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1638) ~[?:?] at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:435) ~[?:?] at io.streamnative.pulsar.handlers.kop.KopEventManager$KopEventThread.doWork(KopEventManager.java:140) ~[ewqichUs9Q6h6lSbSYgTKg/:?] at io.streamnative.pulsar.handlers.kop.utils.ShutdownableThread.run(ShutdownableThread.java:108) ~[ewqichUs9Q6h6lSbSYgTKg/:?] ``` ### Modifications * Hide scary `InterruptedException` in KopEventManager during broker shutdown (cherry picked from commit 5bf2416)
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Nov 28, 2023
…ng broker shutdown (streamnative#1874) ### Motivation The following error log is useless, we can change it to debug level. ``` 2023-05-31T04:10:01,281+0000 [kop-event-thread] ERROR io.streamnative.pulsar.handlers.kop.KopEventManager - Error processing event null java.lang.InterruptedException: null at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1638) ~[?:?] at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:435) ~[?:?] at io.streamnative.pulsar.handlers.kop.KopEventManager$KopEventThread.doWork(KopEventManager.java:140) ~[ewqichUs9Q6h6lSbSYgTKg/:?] at io.streamnative.pulsar.handlers.kop.utils.ShutdownableThread.run(ShutdownableThread.java:108) ~[ewqichUs9Q6h6lSbSYgTKg/:?] ``` ### Modifications * Hide scary `InterruptedException` in KopEventManager during broker shutdown (cherry picked from commit 5bf2416) (cherry picked from commit 4d5bc92)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The following error log is useless, we can change it to debug level.
Modifications
InterruptedExceptionin KopEventManager during broker shutdownDocumentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)