This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[oauthclient] Create a zero-dependencies jar: - remove Async HTTP client and use the standard JDK Http client - shade and relocate Jackson Databind, used for JSON #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove Async HTTP client and use the standard JDK Http client - shade and relocate Jackson Databind, used for JSON
Demogorgon314
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #1979 +/- ##
============================================
- Coverage 17.72% 17.28% -0.45%
+ Complexity 751 726 -25
============================================
Files 195 190 -5
Lines 14155 14012 -143
Branches 1322 1312 -10
============================================
- Hits 2509 2422 -87
+ Misses 11463 11414 -49
+ Partials 183 176 -7 |
gaoran10
reviewed
Jul 27, 2023
gaoran10
previously approved these changes
Jul 28, 2023
...-test/src/test/java/io/streamnative/pulsar/handlers/kop/security/oauth/ClientConfigTest.java
Outdated
Show resolved
Hide resolved
.../test/java/io/streamnative/pulsar/handlers/kop/security/oauth/ClientCredentialsFlowTest.java
Outdated
Show resolved
Hide resolved
3 tasks
BewareMyPower
approved these changes
Jul 31, 2023
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Aug 14, 2023
…ent and use the standard JDK Http client - shade and relocate Jackson Databind, used for JSON (streamnative#1979) (cherry picked from commit streamnative@59576f3 , streamnative@b2db1cf) ### Motivation Create a zero-dependencies jar ### Modifications - remove Async HTTP client and use the standard JDK Http client - shade and relocate Jackson Databind, used for JSON Co-authored-by: Enrico Olivelli <enrico.olivelli@datastax.com> (cherry picked from commit 9f3b581)
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Nov 28, 2023
…ent and use the standard JDK Http client - shade and relocate Jackson Databind, used for JSON (streamnative#1979) (cherry picked from commit streamnative@59576f3 , streamnative@b2db1cf) ### Motivation Create a zero-dependencies jar ### Modifications - remove Async HTTP client and use the standard JDK Http client - shade and relocate Jackson Databind, used for JSON Co-authored-by: Enrico Olivelli <enrico.olivelli@datastax.com> (cherry picked from commit 9f3b581) (cherry picked from commit 999cddc)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 59576f3 , b2db1cf)
Motivation
Create a zero-dependencies jar
Modifications
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)