-
Notifications
You must be signed in to change notification settings - Fork 132
add prometheus metric exporter framework #389
add prometheus metric exporter framework #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hangc0276 We can expose metrics through /metrics endpoint of the broker directly, I have add Raw Metrics Provider in Pulsar (apache/pulsar#9021), you can use it to expose additional metrics to the broker metrics endpoint.
The |
84e0f20
to
bc25497
Compare
@codelipenghui Ok, I update the code and use pulsar raw metrics provider to expose kop metrics to pulsar metrics group. Please take a look. Thanks. |
You should fix the code style first. Then please remove Regarding how to enable the monitor for prometheus, we can open a new PR to add the docs. |
opened a new issue for the doc. @codelipenghui @BewareMyPower Would you please help review it again? |
String SERVER_STATUS = "SERVER_STATUS"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String SERVER_STATUS = "SERVER_STATUS"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused variable
tests/src/test/java/io/streamnative/pulsar/handlers/kop/MetricsProviderTest.java
Show resolved
Hide resolved
I've left a few comments, PTAL. |
@BewareMyPower OK, i will fix it |
987df52
to
fd72cc5
Compare
### Motivation #389 exposed the metrics for KoP and added the docs. However, users cannot click into the metrics docs in the main web page. ### Modifications Add the link of metrics docs to README.md. In addition, sync docs/kop.md with README.md so that upgrade.md and reference-metrics.md can both be navigated from SN hub. Then remove the **Upgrade** section because it's duplicated with upgrade.md.
### Motivation #389 exposed the metrics for KoP and added the docs. However, users cannot click into the metrics docs in the main web page. ### Modifications Add the link of metrics docs to README.md. In addition, sync docs/kop.md with README.md so that upgrade.md and reference-metrics.md can both be navigated from SN hub. Then remove the **Upgrade** section because it's duplicated with upgrade.md.
### Motivation #389 exposed the metrics for KoP and added the docs. However, users cannot click into the metrics docs in the main web page. ### Modifications Add the link of metrics docs to README.md. In addition, sync docs/kop.md with README.md so that upgrade.md and reference-metrics.md can both be navigated from SN hub. Then remove the **Upgrade** section because it's duplicated with upgrade.md.
Motivation
KOP doesn't expose prometheus metrics to monitor running stats, which will be hard the debug performance problem.
Changs