This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Fix NPE problems caused by mockZooKeeper API changes when dump version to 2.8.1.26 #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you upgrade the Pulsar dependency to 2.8.1.26 as well? (Current dependency is 2.8.0.15) This change was introduced from apache/pulsar#13066, we should also note it in PR description. |
|
It's a breaking change but it only affects the tests. So I think upgrading Pulsar to 2.8.1.26 is OK and won't cause the compatibility issue like #768. The version upgrade is just to ensure the fix works. |
|
Sorry I missed the fact this is a PR to master branch. We can do the dependency upgrade later. I'll merge this PR first. |
BewareMyPower
approved these changes
Dec 6, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 6, 2021
…951) Fix https://github.com/streamnative/kop/runs/4425667410?check_suite_focus=true#step:5:283 #950 ### Motivation MockZookeeper API was changed in apache/pulsar#13066, the `CreateMode` shouldn't be null. We should use MetadataStore instead of mockZooKeeper since KoP already remove all zkClient usage. ### Modifications Use MetadataStore instead of mockZooKeeper in ProducerIdManagerTest
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 6, 2021
…951) Fix https://github.com/streamnative/kop/runs/4425667410?check_suite_focus=true#step:5:283 #950 ### Motivation MockZookeeper API was changed in apache/pulsar#13066, the `CreateMode` shouldn't be null. We should use MetadataStore instead of mockZooKeeper since KoP already remove all zkClient usage. ### Modifications Use MetadataStore instead of mockZooKeeper in ProducerIdManagerTest
|
Remove the 2.8.1 related labels because this PR uses an API only for 2.9.0 or later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/streamnative/kop/runs/4425667410?check_suite_focus=true#step:5:283
#950
Motivation
MockZookeeper API has changed, the
CreateModeshouldn't be null. We should use MetadataStore instead of mockZooKeeper since KoP already remove all zkClient usage.Modifications
Use MetadataStore instead of mockZooKeeper in ProducerIdManagerTest