Add Cache for event writer. #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Technoboy-:Thanks for your contribution. For this PR, do we need to update docs? |
mattisonchao
previously approved these changes
Jul 25, 2023
| @@ -112,15 +125,14 @@ public CompletableFuture<Void> sendPSKEvent(PSKEvent event) { | |||
|
|
|||
| @Override | |||
| public CompletableFuture<Void> sendEvent(MqttEvent event) { | |||
| CompletableFuture<SystemTopicClient.Writer<MqttEvent>> writerFuture = systemTopicClient.newWriterAsync(); | |||
| CompletableFuture<SystemTopicClient.Writer<MqttEvent>> writerFuture = writerCaches.get(WRITER_KEY); | |||
| return writerFuture.thenCompose(writer -> { | |||
| CompletableFuture<MessageId> writeFuture = ActionType.DELETE.equals(event.getActionType()) | |||
| ? writer.deleteAsync(event.getKey(), event) : writer.writeAsync(event.getKey(), event); | |||
| writeFuture.whenComplete((__, ex) -> { | |||
| if (ex != null) { | |||
| log.error("[{}] send event error.", SYSTEM_EVENT_TOPIC, ex); | |||
There was a problem hiding this comment.
It should be invalidated when the writer has any exceptions.
mattisonchao
approved these changes
Jul 25, 2023
Technoboy-
added a commit
that referenced
this pull request
Jul 25, 2023
Technoboy-
added a commit
that referenced
this pull request
Jul 25, 2023
Technoboy-
added a commit
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add cache for the event writer to avoid creating event writer every time.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)