Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoP accept ws connections #1328

Merged
merged 10 commits into from
Apr 28, 2024
Merged

Conversation

caihualin
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #35

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Using MQTT over WebSocket in MoP.

Modifications

Supported operations

  • Fix document errors

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • [* ] doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Copy link

@caihualin:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@caihualin
Copy link
Contributor Author

Big guy, there is a small error in the using-mqtt-over-websocket.md, it has been fixed, please merge!

Technoboy-
Technoboy- previously approved these changes Apr 28, 2024
@Technoboy- Technoboy- merged commit ab471c6 into streamnative:master Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

websocket connection
2 participants