Allow set null string for avroCodec and parquetCodec #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
reviewed
Nov 28, 2023
src/main/java/org/apache/pulsar/io/jcloud/format/AvroFormat.java
Outdated
Show resolved
Hide resolved
RobertIndie
reviewed
Nov 28, 2023
src/main/java/org/apache/pulsar/io/jcloud/format/ParquetFormat.java
Outdated
Show resolved
Hide resolved
RobertIndie
approved these changes
Nov 28, 2023
shibd
added
release/3.1.0.7
type/enhancement
shibd
added a commit
to shibd/pulsar-io-cloud-storage
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit e569b0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
According docs,
avroCodecandparquetCodeccan set the "null" string to represent no compression.Allow set "null" string for avroCodec and parquetCodec
Verifying this change
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)