refactor: Split consumer.rs file #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentinDUBOIS
approved these changes
Dec 1, 2022
|
So much easier to read! <3. |
|
@CleverAkanoa is this PR ready for review now? |
|
I think so :) |
tisonkun
reviewed
Dec 13, 2022
Co-authored-by: tison <wander4096@gmail.com>
tisonkun
approved these changes
Dec 13, 2022
tisonkun
changed the title
|
Thanks @tisonkun <3 |
Merged
| task::{Context, Poll}, | ||
| }; | ||
|
|
||
| use async_std::prelude::Stream; |
There was a problem hiding this comment.
This causes a compile error when the async_std feature is not active.
There was a problem hiding this comment.
We can use futures::Stream which is runtime agnostic. I filed a patch: #250.
| time::{Duration, Instant}, | ||
| }; | ||
|
|
||
| use async_std::prelude::Stream; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to ease the code navigability of the consumer part.
consumer.rs involves more than 2000 lines of codes, it's quite hard to know where you are.
Even all structure are related to consumer, they can be split in more than one files.
No code has been changed, only moved and visibility opened when it was mandatory.