Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close connection #246

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Conversation

CleverAkanoa
Copy link
Collaborator

@CleverAkanoa CleverAkanoa commented Dec 20, 2022

Attempt to create a close connection from pulsar client

I used the java client api as model https://docs.streamnative.io/cloud/stable/connect/client/connect-java

@waxzce
Copy link

waxzce commented Dec 27, 2022

We need this ;-)

src/producer.rs Outdated
.sender()
.close_producer(self.id)
.await
.map(|_| ())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.map(|_| ())
.map(drop)

@CleverAkanoa CleverAkanoa marked this pull request as ready for review January 4, 2023 09:28
@CleverAkanoa CleverAkanoa changed the title WIP: close connection close connection Jan 5, 2023
@FlorentinDUBOIS FlorentinDUBOIS merged commit 1ef7da6 into streamnative:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants