Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: end client rx upon disconnection error #305

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

rliang
Copy link
Contributor

@rliang rliang commented Jan 18, 2024

Currently, consumers can enter an infinite error logging loop when Pulsar goes down (even if it goes back up).

The cause seems to be that, when registering an event source, the send loop never exits, even if the event sink is disconnected. This patch fixes it.

@klaatu01
Copy link
Contributor

klaatu01 commented Mar 5, 2024

@tisonkun I can vouch for this issue:
Screenshot 2024-03-05 at 11 02 50

@tisonkun
Copy link
Contributor

tisonkun commented Mar 5, 2024

I don't have the permission to handle this repo traffic now, sorry.

@freeznet
Copy link
Member

This PR lgtm, and i will merge it once the checks all passes.

@tisonkun just wanna to check with you if you are willing to continue work on this repo? if yes, sijie could grant the permissions to you so you could continue to work on this repo when you have time. thanks.

@freeznet freeznet merged commit a633e70 into streamnative:master Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants