Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] clean PulsarMetadataReader #116

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Conversation

nlu90
Copy link
Collaborator

@nlu90 nlu90 commented Mar 27, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #113

Motivation

Prepare the code and classes for solving #113

Modifications

  1. Rename the PulsarMetadataReader class to PulsarHelper
  2. Rename PulsarMetadataReader instances to pulsarHelper accordingly
  3. Update several internal methods to private scope

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@nlu90 nlu90 requested a review from a team as a code owner March 27, 2023 22:13
@nlu90 nlu90 self-assigned this Mar 27, 2023
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Mar 27, 2023
@nlu90 nlu90 changed the title rename PulsarMetadataReader to PulsarHelper clean PulsarMetadataReader Mar 27, 2023
@nlu90 nlu90 merged commit 3aa6493 into master Mar 28, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the neng/rename-pulsarmetadatareader branch March 28, 2023 03:50
@nlu90 nlu90 changed the title clean PulsarMetadataReader [Improve] clean PulsarMetadataReader Mar 28, 2023
@nlu90 nlu90 added this to the 2023-04 v3.2.0.2 milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants