clean initial offset setup #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nlu90:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
doc-info-missing
|
@nlu90:Thanks for providing doc info! |
nlu90
commented
Apr 5, 2023
Comment on lines
-470
to
-475
| case UserProvidedMessageId(mid) if mid == MessageId.earliest => | ||
| UserProvidedMessageId(mid) | ||
| case UserProvidedMessageId(mid) if mid == MessageId.latest => | ||
| UserProvidedMessageId(mid) | ||
| case UserProvidedMessageId(mid) => | ||
| fetchOffsetForTopic(poolTimeoutMs, reportDataLoss, tp, mid) |
There was a problem hiding this comment.
The intention of this code segment is not clear to me.
We can handle them later if needed.
jiangpengcheng
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #107
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Currently, the connector will create readers with already-used subscription names to set up starting offsets. This causes conflicts and even requires additional permission or subscription work.
Modifications
CachedConsumerinstead of ad-hoc reader to establish initial offsetsVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-docinternal changes
doc(If this PR contains doc changes)