Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Spark 3.4.0 #133

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

caseyrathbone
Copy link
Contributor

Motivation

We would like to use pulsar-spark with Spark 3.4.0

Modifications

Updated pom.xml to Apache Spark 3.4.0 and adjusted TimestampFormatter parameters

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:

  • This change added tests and can be verified as follows:

Documentation

Check the box below.

Need to update docs?

  • doc-required
  • no-need-doc
  • doc

@caseyrathbone caseyrathbone requested review from nlu90 and a team as code owners May 4, 2023 16:25
@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 4, 2023
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this patch, shall pulsar-spark still be compatible with <=3.2?

@nlu90
Copy link
Collaborator

nlu90 commented May 10, 2023

@tisonkun I doubt the compatibility.

Ideally, we should use the mvn profile to manage multiple spark versions.

@nlu90 nlu90 merged commit 3feaf39 into streamnative:master Aug 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants